Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pihole-exporter NixOS module #214809

Merged
merged 1 commit into from
Feb 6, 2023
Merged

fix: pihole-exporter NixOS module #214809

merged 1 commit into from
Feb 6, 2023
+29 −16

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 5, 2023

The interval configuration option doesn't exist and has been removed (see release 0.3.0, and this PR in particular)
The timeout configuration option has been added in eko/pihole-exporter#110

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 5, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 5, 2023
@drupol drupol force-pushed the fix/update-pihole-exporter branch from 5db23a1 to c2b6817 Compare February 6, 2023 08:14
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Feb 6, 2023
@drupol drupol force-pushed the fix/update-pihole-exporter branch 3 times, most recently from 98c5d40 to 8dea8c3 Compare February 6, 2023 08:30
@drupol drupol force-pushed the fix/update-pihole-exporter branch 2 times, most recently from 4e27c39 to b6d86d0 Compare February 6, 2023 09:28
@NickCao
Copy link
Member

NickCao commented Feb 6, 2023

diff LGTM, one last nitpick: the commit message should begin with nixos/prometheus-pihole-exporter: ...

@drupol
nixos/prometheus-pihole-exporter: update configuration options
4e7f20a 
The `interval` configuration option doesn't exist and has been removed.
The `timeout` configuration option has been added.
@drupol
Copy link
Contributor Author

drupol commented Feb 6, 2023

Done.

@drupol drupol force-pushed the fix/update-pihole-exporter branch from b6d86d0 to 4e7f20a Compare February 6, 2023 10:36
@NickCao NickCao merged commit 701390c into NixOS:master Feb 6, 2023
@drupol drupol deleted the fix/update-pihole-exporter branch February 6, 2023 10:37
@drupol
Copy link
Contributor Author

drupol commented Feb 6, 2023

Thanks!

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickCao NickCao NickCao approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @NickCao